Remove HAVE_STRING_H, HAVE_STDARG_H, and HAVE_STDLIB_H #13
Conversation
These symbols are defined by the build system to check the presence of the standard C89 headers. Since C89 is really widely adopted across systems already, these checks are obsolete today and not needed. http://port70.net/~nsz/c/c89/c89-draft.html#4.1.2 Some of these checks are also removed since PHP-7.4.
|
Is here even anyone checking pull requests? |
@petk Who did you tickle to merge the PR's? There are some more PR's waiting to be reviewed and merged... |
|
I've merged it since no one is looking these I think and I know very well the changes in this PR to be ok... But issue is that I'm not that "at home" with other C parts and changes in pull requests. I would much prefer for someone who is also releasing this extension on pecl to look at pull requests. Is there something that is confirmed ok and can be merged here? |
|
#14 (comment) |
|
#15 is confirmed as well. |
|
Looks like this one is OK as well: |
|
Awesome then. Merges coming up. Thank you for the reviews... |
|
@0mars said he would look at them this weekend: |
For @0mars and @petk Only the first commit of https://github.com/php/pecl-search_engine-solr/pull/14/commits should be merged. The ones relating to appVeyor can be ignored. |
|
@Jan-E about #16 I'm not sure I'm up to this merge. I'm not sure I'll even be able to test this properly - there are changes of the bug title. Thanks. I still think it is best for someone who has been around this extension longer than I to look at these. |
|
The appveyor changes were just to show some test results online, but many were skipped because of the lack of a running SOLR server on Appveyor. See this ancient comment of @0mars about that one: I removed the Appveyor changes from the PR: #14 |
3 participants
These symbols are defined by the build system to check the presence of the standard C89 headers. Since C89 is really widely adopted across systems already, these checks are obsolete today and not needed.
http://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
Some of these checks are also removed since PHP-7.4.